Browse Source

Properly sanitize the "switch_env" parameter and take it into account only if it contains a valid value.

git-svn-id: http://svn.code.sf.net/p/itop/code/trunk@4238 a333f486-631f-4898-b8df-5754b55c2be0
dflaven 9 years ago
parent
commit
4f4009384e
1 changed files with 4 additions and 3 deletions
  1. 4 3
      application/startup.inc.php

+ 4 - 3
application/startup.inc.php

@@ -28,10 +28,11 @@ require_once(APPROOT.'/core/cmdbobject.class.inc.php');
 require_once(APPROOT.'/application/utils.inc.php');
 session_name('itop-'.md5(APPROOT));
 session_start();
-if (isset($_REQUEST['switch_env']))
+$sSwitchEnv = utils::ReadParam('switch_env', null);
+if (($sSwitchEnv != null) && (file_exists(APPCONF.$sSwitchEnv.'/'.ITOP_CONFIG_FILE)))
 {
-	$sEnv = $_REQUEST['switch_env'];
-	$_SESSION['itop_env'] = $sEnv;
+	$_SESSION['itop_env'] = $sSwitchEnv;
+	$sEnv = $sSwitchEnv;
 	// TODO: reset the credentials as well ??
 }
 else if (isset($_SESSION['itop_env']))